-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: bump bridge controllers #39074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (5 files, +344 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Builds ready [c9c0adb]
UI Startup Metrics (1323 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@metamaskbot update-policies |
Builds ready [a09f6fc]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
| "@metamask/controller-utils": true, | ||
| "@metamask/superstruct": true, | ||
| "@metamask/utils": true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MV2 policy missing essential bridge-controller permissions
Medium Severity
The MV2 policy for @metamask/transaction-pay-controller>@metamask/bridge-controller has only 3 packages and no globals, while the browserify version has 6 globals and 15+ packages including critical dependencies like @ethersproject/*, multichain-network-controller, polling-controller, and bignumber.js. Even within MV2, the sibling @metamask/bridge-status-controller>@metamask/bridge-controller entry has 10 packages and a global. This dramatic inconsistency suggests the MV2 policy is missing essential permissions that could cause LavaMoat to block legitimate bridge-controller operations at runtime.
Builds ready [dbce0d1]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [a4a217d]
UI Startup Metrics (1344 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [a4a217d]
UI Startup Metrics (1344 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [a4a217d]
UI Startup Metrics (1344 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Bumps the bridge controller and bridge status controller to the most recent versions.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Upgrade bridge controllers and align policies
@metamask/bridge-controllerand@metamask/bridge-status-controllerto64.3.0inpackage.json, with correspondingyarn.lockupdates (e.g.,@metamask/[email protected],@metamask/[email protected],@metamask/[email protected],@metamask/[email protected]) and adds@metamask/remote-feature-flag-controllerbeta/experimental/flask/mainand webpackmv2) to:@metamask/transaction-pay-controller>@metamask/bridge-controllerresource with required globals/packages and nested entries for...>@metamask/multichain-network-controller,...>@metamask/network-controller, and...>@metamask/polling-controller@metamask/transaction-pay-controllerpackage reference to@metamask/transaction-pay-controller>@metamask/bridge-controllerinstead of direct@metamask/bridge-controllerWritten by Cursor Bugbot for commit a4a217d. This will update automatically on new commits. Configure here.